Hot reloading support via import.meta.hot #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
changed the title
Closed
|
Hey @guybedford Just found this PR. Are you still planning on merging it?
If you are hesitant on merging it because of this reason, maybe I suggest instead of baking in websocket support, a function should be exposed which anyone can call in order to process these messages. I'm interested in this, because i'm building a browser based IDE at @gratico, and hence I think a this approach is more generic and useful than making it dependent on websocket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
import.meta.hotAPI from Vite (https://vitejs.dev/guide/api-hmr.html).The hot reloader is implemented as an extension using initialized hooks that executes before es-module-shims.
In addition this PR adds support for
subgraphPassthrough: true, which effectively disables the performance feature from #208. This at least provides a way around the instancing issues which seems useful.